-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PostgreSQL minor version updates (17.1, 16.5, 15.9, 14.14) #9727
Conversation
There were no significant conflicts |
5391 tests run: 5171 passed, 0 failed, 220 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
5a0f8c6 at 2024-11-13T10:04:21.981Z :recycle: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
(I didn't dig deep into the list of upstream changes)
Did you cherry-pick https://gitlab.com/dalibo/postgresql_anonymizer/-/commit/23aac2f78ef5926722cc38f34f448d51fbf3673b for the timezone issue? |
I'm getting the failure with vanilla Postgres and vanilla postgresql_anonymizer checkout that includes that commit. I believe that fix was insufficient. Good point that we're missing that in our version of pg_anon though. That means that the patch that I included here probably won't work. |
d0f32eb
to
cc64739
Compare
It did apply anyway, so we're good. |
cc64739
to
0fefd65
Compare
This includes a patch to temporarily disable one test in the pg_anon test suite. It is an upstream issue, the test started failing with the new PostgreSQL minor versions because of a change in the default timezone used in tests. We don't want to block the release for this, so just disable the test for now. See https://gitlab.com/dalibo/postgresql_anonymizer/-/commit/199f0a392b37c59d92ae441fb8f037e094a11a52#note_2148017485
0fefd65
to
5a0f8c6
Compare
Corresponding postgres repository PRs:
neondatabase/postgres#524
neondatabase/postgres#525
neondatabase/postgres#526
neondatabase/postgres#527